feat(code): GitHub inbox connect banner and API integration#1897
Merged
feat(code): GitHub inbox connect banner and API integration#1897
Conversation
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/code/src/renderer/features/inbox/components/list/GitHubConnectionBanner.tsx
Line: 89-91
Comment:
**Redundant `disabledReason` during loading conflicts with tooltip**
When `connecting=true`, both `loading={connecting}` and `disabledReason="GitHub connection is starting"` are passed together with a non-null `tooltipContent`. `buildTooltipContent` will then render a two-section tooltip: the full info content *plus* "Disabled because GitHub connection is starting." Since the button is loading and the spinner already communicates the state, the combined tooltip is redundant and potentially confusing if the user hovers over the disabled wrapper span. Passing `disabledReason={null}` (or omitting it) while `loading=true` would give cleaner feedback — the spinner is sufficient.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat(code): GitHub inbox banner connect ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Twixes
force-pushed
the
feat/code-github-connect-banner
branch
2 times, most recently
from
717b53c to
c5bbb35
Compare
Use project-scoped GitHub integration for banner copy, call github/start from the API with connect_from=posthog_code, and fall back to Personal integrations in the browser. Add startGithubUserIntegrationConnect on PostHogAPIClient; support loading + spinner on shared Button with an in-flight guard on the banner. Point main GitHub authorize next step at /account-connected/github-login for PostHog web companion behavior.
Twixes
force-pushed
the
feat/code-github-connect-banner
branch
from
d8950a3 to
1c0f5c0
Compare
adboio
approved these changes
Apr 28, 2026
|
|
||
| // ── Signal source configs ─────────────────────────────────────────────── | ||
| const { data: signalSourceConfigs } = useSignalSourceConfigs(); | ||
| const { data: signalSourceConfigs, isPending: signalSourceConfigsPending } = |
Contributor
There was a problem hiding this comment.
Suggested change
| const { data: signalSourceConfigs, isPending: signalSourceConfigsPending } = | |
| const { isPending: signalSourceConfigsPending, data: signalSourceConfigs } = |
Member
Author
There was a problem hiding this comment.
I think formatter will complain here if we do this, but maybe not 🤔
| Connect your GitHub profile to highlight what's relevant to you | ||
| </span> | ||
| {connecting ? ( | ||
| <Spinner size="1" className="shrink-0 text-current" /> |
Contributor
There was a problem hiding this comment.
[nit] i think this spinner shows up the entire time the flow happens in-browser, right? if so maybe we can put some help text more prominently, like what's in the tooltip currently, so it's obvious the user needs to go to the browser and isn't actually waiting on any processes in-app
Member
Author
There was a problem hiding this comment.
Well, had to do it manually like in the old days
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding support for the new UserIntegration in PostHog Code's Inbox.
Making
GitHubConnectionBanneralways starts the PostHog CloudUserIntegrationflow viastartGithubUserIntegrationConnect(projectId). This is much better than doing the social auth thing.Also, fixed
InboxSourcesDialogwidth, and when the project itself has no access configured, we auto-open the dialog to nudge the user.PostHog app / web changes (unified
account-connectedGitHub routes and redirects,UserIntegrationgithub/startendpoint): Graphite – PostHog/posthog#55304